RDKB-64347: Fixing coverity issues by bharathivelp · Pull Request #1096 · rdkcentral/OneWifi

bharathivelp · 2026-04-27T08:10:32Z

Reason for change: Fixing Low priority coverity issues.
Test Procedure: Build should be successful and the regression test should also succeed.

Risks: Low
Priority: P1
Signed-off-by: [email protected]

Copilot

Pull request overview

This PR addresses Coverity-reported issues across WiFi monitoring, webconfig consumer logging, and the WiFi blaster active-measurement flow.

Changes:

Removes an ineffective/null check and simplifies disconnect cleanup logic in associated-client stats collection.
Adjusts STA connection status log formatting in the webconfig consumer.
Avoids holding the blaster mutex while collecting (potentially slow) system health stats by restructuring the resource-gathering condition.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`source/stats/wifi_stats_assoc_client.c`	Removes dead/null logic, tweaks disconnect removal condition, and adds a `sta_map` NULL guard before event building.
`source/sampleapps/webconfig_consumer_apis.c`	Updates STA connect/disconnect printf formats.
`source/apps/blaster/wifi_blaster.c`	Refactors resource collection into a `resource_ok` boolean and releases the mutex during resource collection.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

verann462 · 2026-05-04T07:59:22Z

+    csifptr = fopen(CSI_FILE, "r");
+
+    /* Secure temp file */
+    mode_t old_umask = umask(0077);


Mask should be only RW for the group and the user. (0066)

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

        p_data->raw_data_len = bytes_size;

-    } else if (strcmp(extension, "Bssid") == 0) {
+    } else if (strncmp(name + nlen - strlen("Bssid"), "BSSID", strlen("Bssid")) == 0) {


+        printf("%s:%d: Station disconnected with external AP:%d radio:%u\r\n",
                __func__, __LINE__, conn_status, index - 1);


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

    printf("%s:%d Rbus event name=%s\n",__FUNCTION__, __LINE__, event->name);

-    sscanf(event->name, "Device.WiFi.STA.%d.InterfaceName", &index);
+    if (sscanf(event->name, "Device.WiFi.STA.%d.InterfaceName", &index) != 1) {


+    if (sscanf(name, "Device.WiFi.STA.%u.", &index) != 1) {
+        wifi_util_error_print(WIFI_CTRL, "%s Failed to parse STA index from %s\n", __FUNCTION__, name);
+        return bus_error_invalid_input;
+    }

-    sscanf(name, "Device.WiFi.STA.%d.%s", &index, extension);
-    if (index > getNumberRadios()) {
-        wifi_util_error_print(WIFI_CTRL, "%s Invalid index %d\n", __FUNCTION__, index);
+    if (index == 0 || index > getNumberRadios()) {
+        wifi_util_error_print(WIFI_CTRL, "%s Invalid index %u\n", __FUNCTION__, index);
        return bus_error_invalid_operation;
    }

    vap_map = &mgr->radio_config[(index - 1)].vaps.vap_map;
    vap_index = get_sta_vap_index_for_radio(&mgr->hal_cap.wifi_prop, index - 1);

-    if (strcmp(extension, "Connection.Status") == 0) {
+    if (strncmp(name + nlen - strlen("Connection.Status"), "Connection.Status", strlen("Connection.Status")) == 0) {


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+    /* ---- Connection.Status ---- */
+    if (strncmp(attr, "Connection.Status", strlen("Connection.Status")) == 0) {


Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

navyasher · 2026-05-07T04:19:51Z

-    sscanf(name, "Device.WiFi.STA.%d.%s", &index, extension);
-    if (index > getNumberRadios()) {
-        wifi_util_error_print(WIFI_CTRL, "%s Invalid index %d\n", __FUNCTION__, index);
+    /* WiFi */


change not needed since low priority

Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: [email protected]

bharathivelp requested a review from a team as a code owner April 27, 2026 08:10

navyasher requested a review from Copilot April 27, 2026 09:53

Copilot started reviewing on behalf of navyasher April 27, 2026 09:54 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

Comment thread source/sampleapps/webconfig_consumer_apis.c Outdated

Comment thread source/apps/blaster/wifi_blaster.c Outdated

Comment thread source/stats/wifi_stats_assoc_client.c Outdated

Comment thread source/sampleapps/webconfig_consumer_apis.c Outdated

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 157bd13 to 13211a6 Compare April 27, 2026 10:25

navyasher requested a review from Copilot April 27, 2026 10:55

Copilot started reviewing on behalf of navyasher April 27, 2026 10:55 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

bharathivelp force-pushed the RDKB_LOW_ISSUES branch 2 times, most recently from a04e6b5 to 6bcb5ab Compare April 29, 2026 12:14

navyasher requested a review from Copilot April 29, 2026 12:40

Copilot started reviewing on behalf of navyasher April 29, 2026 12:41 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread lib/pktgen/pktgen.c

Comment thread source/sampleapps/webconfig_consumer_apis.c Outdated

Comment thread source/sampleapps/wifievents_consumer_sample.c Outdated

Comment thread source/sampleapps/wifievents_consumer_sample.c Outdated

navyasher force-pushed the RDKB_LOW_ISSUES branch from 6bcb5ab to 100fb87 Compare April 29, 2026 14:26

navyasher requested a review from Copilot April 29, 2026 14:27

Copilot started reviewing on behalf of navyasher April 29, 2026 14:28 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread source/sampleapps/wifievents_consumer_sample.c Outdated

navyasher force-pushed the RDKB_LOW_ISSUES branch from 100fb87 to 78e2ae2 Compare April 29, 2026 15:37

navyasher requested a review from Copilot April 29, 2026 15:37

Copilot started reviewing on behalf of navyasher April 29, 2026 15:38 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Comment thread source/sampleapps/webconfig_consumer_apis.c

Comment thread source/sampleapps/wifievents_consumer_sample.c

Comment thread source/sampleapps/wifievents_consumer_sample.c Outdated

navyasher force-pushed the RDKB_LOW_ISSUES branch 3 times, most recently from d9fe651 to f54cf35 Compare April 30, 2026 10:57

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from f54cf35 to 0b4e4a6 Compare April 30, 2026 12:11

navyasher requested a review from Copilot April 30, 2026 12:31

Copilot started reviewing on behalf of navyasher April 30, 2026 12:36 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread source/sampleapps/wifievents_consumer_sample.c

Comment thread source/sampleapps/webconfig_consumer_apis.c

Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 0b4e4a6 to 5d5a08c Compare April 30, 2026 13:06

navyasher requested a review from Copilot April 30, 2026 13:07

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 26bde9b to 2518f8f Compare May 4, 2026 06:27

navyasher requested a review from Copilot May 4, 2026 06:27

Copilot started reviewing on behalf of navyasher May 4, 2026 06:28 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated

Comment thread source/sampleapps/webconfig_consumer_apis.c Outdated

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 2518f8f to e24348c Compare May 4, 2026 06:43

navyasher requested a review from Copilot May 4, 2026 06:43

Copilot started reviewing on behalf of navyasher May 4, 2026 06:44 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread source/sampleapps/wifievents_consumer_sample.c

Comment thread source/sampleapps/webconfig_consumer_apis.c

Comment thread source/sampleapps/webconfig_consumer_apis.c

verann462 reviewed May 4, 2026

View reviewed changes

Comment thread source/sampleapps/wifievents_consumer_sample.c

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from e24348c to 14017f9 Compare May 4, 2026 09:32

navyasher requested a review from Copilot May 4, 2026 09:38

Copilot started reviewing on behalf of navyasher May 4, 2026 09:39 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 14017f9 to 1e2dbd4 Compare May 4, 2026 12:10

navyasher requested a review from Copilot May 4, 2026 12:26

Copilot started reviewing on behalf of navyasher May 4, 2026 12:26 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from 1e2dbd4 to c9a7f32 Compare May 5, 2026 10:40

navyasher requested a review from Copilot May 5, 2026 10:44

Copilot started reviewing on behalf of navyasher May 5, 2026 10:44 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

bharathivelp force-pushed the RDKB_LOW_ISSUES branch 2 times, most recently from 000804a to d2b21dd Compare May 5, 2026 12:10

navyasher requested a review from Copilot May 5, 2026 12:14

Copilot started reviewing on behalf of navyasher May 5, 2026 12:15 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread source/core/wifi_ctrl_rbus_handlers.c Outdated

Comment thread source/sampleapps/webconfig_consumer_apis.c

navyasher reviewed May 7, 2026

View reviewed changes

RDKB-64347: Fixing coverity issues

f865f95

Reason for change: Fixing Low priority Coverity issues. Test Procedure: Build should be successful and the regression test should also succeed. Risks: Low Priority: P1 Signed-off-by: [email protected]

bharathivelp force-pushed the RDKB_LOW_ISSUES branch from d2b21dd to f865f95 Compare May 7, 2026 06:14

		printf("%s:%d: Station disconnected with external AP:%d radio:%u\r\n",
		__func__, __LINE__, conn_status, index - 1);

		/* ---- Connection.Status ---- */
		if (strncmp(attr, "Connection.Status", strlen("Connection.Status")) == 0) {

Conversation

bharathivelp commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

verann462 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

bharathivelp commented Apr 27, 2026 •

edited

Loading